SOLR-18269: Restore -c as a no-op function for bin/solr start#4473
Merged
Conversation
janhoy
approved these changes
May 29, 2026
Contributor
janhoy
left a comment
janhoy
left a comment
There was a problem hiding this comment.
Looks good, but I think it is unnecessary to print the -c flag in the --help docs, as it won't help a single soul 🤣
| echo "" | ||
| echo " -c or --cloud No-op. Solr starts in cloud mode by default; this flag is accepted for" | ||
| echo " compatibility with previous Solr scripts. Cannot be combined with --user-managed." | ||
| echo "" |
Contributor
There was a problem hiding this comment.
Do we even need to mention the flag if it's noop? We could leave it an expert stealth option?
Contributor
Author
There was a problem hiding this comment.
humm... yeah, i went back and forth on it... was thinking that having this magic variable not be documented is worse? but I can see not having the it documented but still giving the warning. and the help is getting so long!
Contributor
|
Add a changelog? |
Signed-off-by: Eric Pugh <epugh@opensourceconnections.com>
epugh
added a commit
that referenced
this pull request
Jun 3, 2026
Signed-off-by: Eric Pugh <epugh@opensourceconnections.com> (cherry picked from commit c2123ca)
epugh
added a commit
that referenced
this pull request
Jun 3, 2026
Signed-off-by: Eric Pugh <epugh@opensourceconnections.com> (cherry picked from commit c2123ca)
Contributor
|
Thanks! Let's get a 10.1 out there soon to fix the operator support story! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://issues.apache.org/jira/browse/SOLR-18269
Description
Restore
-cas no-op function to bin/solr start.Solution
Burps out a mention. I used claude. Added a bats test.
Tests
bats.